Archive for TIDY UP YOUR CODE

[TIDY UP YOUR CODE] :: if – elseif – elseif – elseif – else

6. Feb, 2009  No Comment

I thought about doing an extra section called ‘TIDY UP YOUR CODE’.
From time to time I will post some tips how you can write reader-friendly code.
So Let’ start with the first topic: if – elseif – elseif – elseif – else

Have you ever seen something like this ?

if(expressionA)
  1. {
  2.   .. do something ..
  3. }
  4. elseif(expressionB)
  5. {
  6.   .. do something else..
  7. }
  8. elseif(expressionC)
  9. {
  10.   .. do something else..
  11. }
  12. elseif(expressionD)
  13. {
  14.   .. do something else..
  15. }
  16. else
  17. {
  18.   .. do something else..
  19. }

Code like this is hard to read, don’t you agree with this?
TIDY IT UP! Use a switch instead:

switch(true)
  1. {
  2.   case expressionA:
  3.   {
  4.     .. do something ..
  5.   }; break;
  6.  
  7.   case expressionB:
  8.   {
  9.     .. do something else ..
  10.   }; break;
  11.  
  12.   case expressionC:
  13.   {
  14.     .. do something else ..
  15.   }; break;
  16.  
  17.   case expressionD:
  18.   {
  19.     .. do something else ..
  20.   }; break;
  21.  
  22.   default:
  23.   {
  24.     .. do something else ..
  25.   }; break;
  26. }

In my opinion this is great :-}